Handle Go keywords in Protobuf definitions #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a handful of places, we use lowercased versions of Protobuf identifiers as unexported Go symbols. When we do so, we need to handle Go keywords specially. In practice, this comes up because one of the `googleapis` SQL packages has a service with an `Import` RPC. Fixes #346.
pkwarren
approved these changes
Aug 16, 2022
amckinney
approved these changes
Aug 16, 2022
alexandrem
pushed a commit
to alexandrem/connect-go
that referenced
this pull request
Aug 17, 2022
akshayjshah
added a commit
that referenced
this pull request
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a handful of places, we use lowercased versions of Protobuf
identifiers as unexported Go symbols. When we do so, we need to handle
Go keywords specially. In practice, this comes up because one of the
googleapisSQL packages has a service with anImportRPC.Fixes #346.