Try to read full prefix in envelope reader #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hey @njiang747 , I think the fix is a great find! I added a testcase to show that fails when removing your patch. |
jhump
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this fixes a bug where calling to
r.reader.Readbefore all 5 bytes of the prefixes are ready causes an unnecessaryErrUnexpectedEOF(resulting in a client errorinvalid_argument: protocol error: incomplete envelope: unexpected EOF).Switching to use
io.ReadFullguarantees that theenvelopReaderwill wait until the full prefixes is available before proceeding. Error handling should be identical to before due to the semantics ofio.ReadFull. If fewer than 5 bytes are read and thenEOFis hit, it will returnErrUnexpectedEOF. If any other error is hit, it will be returned as expected.