Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure URL resiliency #17

Merged
merged 11 commits into from
Mar 7, 2023
Merged

Ensure URL resiliency #17

merged 11 commits into from
Mar 7, 2023

Conversation

buildbreaker
Copy link
Contributor

@buildbreaker buildbreaker commented Mar 6, 2023 •
edited

Adding URI parsing resiliency by relying on URI to help parse the host and scheme. The previous implementation contained some brittleness when the user sets a host to be https://example.com/ rather than https://example.com

Resolves #12

rebello95
rebello95 reviewed Mar 6, 2023
View reviewed changes
Copy link
Contributor

@rebello95 rebello95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please also add some notes to the PR description / reference any relevant issues?

library/src/test/kotlin/build/buf/connect/impl/ProtocolClientTest.kt Outdated Show resolved Hide resolved
@kohenkatz
Copy link
Contributor

You changed the unary method, but missed the same code in the bidirectionalStream method (line 144).

@buildbreaker @rebello95
Update library/src/test/kotlin/build/buf/connect/ProtocolClientConfig…
6800e20 
…Test.kt

Co-authored-by: Michael Rebello <me@michaelrebello.com>
@buildbreaker buildbreaker merged commit daf6a9e into main Mar 7, 2023
@buildbreaker buildbreaker deleted the achiu/ensure-url-resiliency branch March 7, 2023 00:14
@kohenkatz kohenkatz mentioned this pull request Mar 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kohenkatz kohenkatz kohenkatz left review comments

@rebello95 rebello95 rebello95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Base URL has no validation
3 participants
@buildbreaker @kohenkatz @rebello95