Update send() to forward all errors #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebello95
approved these changes
Mar 9, 2023
buildbreaker
commented
Mar 9, 2023
| @@ -56,8 +56,12 @@ class Stream( | |||
| if (isClosed()) { | |||
| return Result.failure(IllegalStateException("cannot send. underlying stream is closed")) | |||
| } | |||
| onSend(buffer) | |||
| return Result.success(Unit) | |||
| return try { | |||
There was a problem hiding this comment.
This is the contract with the underlying network -- we expect onSend to be unsafe and will handle that failure appropriately.
| @@ -193,7 +193,7 @@ internal class PipeDuplexRequestBody( | |||
| bufferedSink.writeAll(buffer) | |||
| bufferedSink.flush() | |||
| } | |||
| } catch (e: Throwable) { | |||
| } finally { | |||
There was a problem hiding this comment.
Don't swallow these errors anymore and let the caller handle errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #23
I'm working on getting some Android based unit tests working which should validate this behavior. However, I think it might incur some risk for our release tomorrow so I will have to do that work in a separate PR.