cardinality violations should use error code "unimplemented" #269
Comments
rebello95
added a commit
that referenced
this issue
Jun 8, 2024
This PR includes updates to fix all outstanding conformance test failures and removes the corresponding opt-outs. All changes are validated by the conformance test suite. Many of these fixes are similar to connectrpc/connect-kotlin#248 and connectrpc/connect-kotlin#274. Resolves #268. Resolves #269. Resolves #270. This should also be one of the final changes before v1.0 #222. --------- Signed-off-by: Michael Rebello <me@michaelrebello.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The gRPC docs for error codes state that both client and server should use the
unimplementedcode for cardinality violations. See table at the bottom of this doc (you can search for “cardinality violation” in the doc): https://grpc.github.io/grpc/core/md_doc_statuscodes.html.A cardinality violation is when a stream contains an incorrect number of messages. Specifically, when a response stream for a unary or client-stream RPC contains zero messages with an OK status or more than one message.
The client in this repo does not report an
unimplementederror code to the application in these cases.The text was updated successfully, but these errors were encountered: