update to latest linter and tools #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update connect-grpchealth-go to the latest golangci-lint, remove some unnecessary //nolint comments, and fix the makefile to work with Go 1.19 (relative paths to executables are no longer allowed https://go.dev/doc/go1.19#os-exec-path).
pkwarren
commented
Aug 10, 2022
| - interfacer # deprecated by author | ||
| - ireturn # "accept interfaces, return structs" isn't ironclad | ||
| - lll # don't want hard limits for line length | ||
| - maintidx # covered by gocyclo | ||
| - maligned # readability trumps efficient struct packing | ||
| - nlreturn # generous whitespace violates house style | ||
| - nosnakecase # deprecated in https://github.com/golangci/golangci-lint/pull/3065 |
There was a problem hiding this comment.
This will be deprecated in next golangci-lint but disabled for now because it causes lint errors on imported generated code: sivchari/nosnakecase#16
| @@ -48,10 +50,3 @@ issues: | |||
| # Don't ban use of fmt.Errorf to create new errors, but the remaining | |||
| # checks from err113 are useful. | |||
| - "err113: do not define dynamic errors.*" | |||
|
|
|||
| exclude-rules: | |||
There was a problem hiding this comment.
This is working now without this exclusion.
| @@ -6,7 +6,8 @@ SHELL := bash | |||
| MAKEFLAGS += --warn-undefined-variables | |||
| MAKEFLAGS += --no-builtin-rules | |||
| MAKEFLAGS += --no-print-directory | |||
| BIN=.tmp/bin | |||
There was a problem hiding this comment.
https://go.dev/doc/go1.19#os-exec-path - We have to change the PATH to allow execution in go 1.19+.
| @@ -37,15 +37,16 @@ func TestHealth(t *testing.T) { | |||
| server := httptest.NewUnstartedServer(mux) | |||
| server.EnableHTTP2 = true | |||
| server.StartTLS() | |||
| defer server.Close() | |||
| t.Cleanup(server.Close) | |||
There was a problem hiding this comment.
These tests work with t.Parallel() if we close the server in the cleanup method.
bufdev
approved these changes
Aug 10, 2022
akshayjshah
pushed a commit
that referenced
this pull request
Jul 26, 2023
Update connect-grpchealth-go to the latest golangci-lint, remove some unnecessary //nolint comments, and fix the makefile to work with Go 1.19 (relative paths to executables are no longer allowed https://go.dev/doc/go1.19#os-exec-path).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update connect-grpchealth-go to the latest golangci-lint, remove some
unnecessary //nolint comments, and fix the makefile to work with Go 1.19
(relative paths to executables are no longer allowed
https://go.dev/doc/go1.19#os-exec-path).