Alternate implementation for issue #92 #118
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implementation more closely mirrors the default otelgrpc implementation in opentelemnetry-contrib
|
|
|
Hey, so based on the pattern that we've already set in this codebase i'm more in favor of https://github.com/bufbuild/connect-opentelemetry-go/pull/98 We've encountered times where the opentelemetry specification doesn't suite our needs and we've added options to modify the behaviour; such as the introduction of If we want the default behaviour to change then this should be opened up as an issue or pr in the opentelemetry specification. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #92
This implementation more closely mirrors the default otelgrpc implementation in opentelemnetry-contrib
By default that implementation does not send events unless they are requested as part of the config.
Much of this work is merely copying and adjusting some of the upstream implementation.