Fix histogram counter for per RPC counts #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On receiving on sending streams recorded multiple values of 1 per RPC. Use the state counters to accumulate the messages and report total per RPC.
emcfarlane
commented
Nov 16, 2023
| attribute.Key(rpcBufConnectStatusCode).String("data_loss"), | ||
| ), | ||
| Count: 1, | ||
| Sum: 0, |
There was a problem hiding this comment.
How should the handler under error respond? Kept the current behaviour, no response count is reported as no message is sent (only error).
| @@ -649,6 +651,7 @@ func TestStreamingMetricsFail(t *testing.T) { | |||
| semconv.RPCSystemKey.String(bufConnect), | |||
| semconv.RPCServiceKey.String(pingv1connect.PingServiceName), | |||
| semconv.RPCMethodKey.String(PingStreamMethod), | |||
| attribute.Key(rpcBufConnectStatusCode).String("data_loss"), | |||
There was a problem hiding this comment.
Includes attributes from error status.
emcfarlane
commented
Nov 16, 2023
| @@ -247,7 +245,13 @@ func (i *Interceptor) WrapStreamingClient(next connect.StreamingClientFunc) conn | |||
| span.SetAttributes(headerAttributes(protocol, responseKey, conn.ResponseHeader(), i.config.responseHeaderKeys)...) | |||
| span.SetStatus(spanStatus(protocol, state.error)) | |||
| span.End() | |||
| instrumentation.duration.Record(ctx, i.config.now().Sub(requestStartTime).Milliseconds(), metric.WithAttributes(state.attributes...)) | |||
| instrumentation.requestsPerRPC.Record(ctx, state.sentCounter, | |||
There was a problem hiding this comment.
Importantly requests are sendCounter here and below for the handler the reverse.
jhump
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On receiving or sending streams we currently recorded multiple values of 1 per RPC. Instead use the state counters to accumulate the number of messages and report the sum total per RPC. See https://opentelemetry.io/docs/specs/semconv/rpc/rpc-metrics/
Changes
rpc.server.requests_per_rpcandrpc.server.responses_per_rpcare reported at the end of the RPC to reflect the total count of messages per RPC