Add descriptions to metrics to match otelgrpc #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When otelconnect and otelgrpc are used in the same project, the Prometheus exporter fails because the descriptions of the metrics produced by the two libraries differ. See connectrpc#154 for details. This PR copies over the metrics descriptions used in the `otelgrpc` instrumentation to metrics produced by `otelconnect`. Fixes connectrpc#154 Signed-off-by: Charith Ellawala <charith@cerbos.dev>
|
|
jhump
approved these changes
Dec 6, 2023
|
This approach seems extremely brittle, but I'm merging anyway since I don't have any better ideas for other solutions/work-arounds right now. Thanks for the contribution, @charithe! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When otelconnect and otelgrpc are used in the same project, the Prometheus exporter fails because the descriptions of the metrics produced by the two libraries differ. See #154 for details.
This PR copies over the metrics descriptions used in the
otelgrpcinstrumentation to metrics produced byotelconnect.Fixes #154