Fix data race on streaming client close #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure we lock the state to handle context cancellation closes. Signed-off-by: Edward McFarlane <emcfarlane@buf.build>
emcfarlane
force-pushed
the
ed/fixStreamingClientClose
branch
from
b13157f
to
7c2a6a3
Compare
Signed-off-by: Edward McFarlane <emcfarlane@buf.build>
emcfarlane
force-pushed
the
ed/fixStreamingClientClose
branch
from
b252beb
to
d745d3d
Compare
emcfarlane
force-pushed
the
ed/fixStreamingClientClose
branch
from
46640e1
to
acbcaa3
Compare
Signed-off-by: Edward McFarlane <emcfarlane@buf.build>
jhump
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a data race for a streaming client on close when a the context is cancelled. This was introduced in #152 where we changed the behaviour to trigger a close on context cancellation. The state must be locked to avoid a data race with Send/Receive calls.
Closes #170, #171.