[Resolves #10] ✨Add Sample Retrier #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds previousAttempts in preparation for basic retrier. - Adds tests that validate previousAttempts is correctly incremented. - Adds updates plugin handlers to all through, matching their protocol. - Adds tests that validate throwing errors rethrows up correctly. - Replaces unused closure parameters with underscore to reduce noise.
- Passes a response, if any, to retriers. - Improves documentation of various HTTPNetworking types. - Converts `HTTPMethod` to a struct for external extensibility purposes.
- Adds convenience functions to HTTPRequest for each plugin's zip. - Adds tests to validate the convenience functions. - Adds some mark docs.
Removes the throwing capability of validator to avoid confusion with the returned result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #10
HTTPNetworkingplugins and types.HTTPURLResponse?to retriers.Resulttype.RetryStrategytoRetryDecisionto allow the name to be used for the sample retrier.