Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy exporter attribute instead of modifying parent class #105

Merged
merged 2 commits into from
Dec 7, 2021

Conversation

daradib
Copy link
Contributor

@daradib daradib commented Dec 4, 2021

Fixes #104.

@connorferster connorferster merged commit 90ef142 into connorferster:master Dec 7, 2021
@macv-hub
Copy link

It seems this change has been reverted so the problem still persists for jupyter notebook and jupyter lab where the default class attribute HTMLHideInputExporter.exclude_input.default_value is set to True and therefore the parent class attribute. In my humble opinion, making a copy of the attribute made sense to avoid the same behaviour using different exporters. However, I feel the real issue is with VScode where the exporter doesn't show the 'no input' options when exporting.

I include this image to illustrate the behaviour without copy command:
image

It appears that handcalcs.exporters.py doesn't add the functionality intended to vscode. Not sure if this can be configured within the IDE rather than hardcoded. Another issue is that any other jupyter notebooks are also not showing any input even when handcalcs is not imported. Does anyone get the same?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nbconvert exports always missing input
4 participants