Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #115, #120, reverted changes to exporter as a workaround for VS Code #119

Merged
merged 5 commits into from
May 14, 2022

Conversation

omouraenko
Copy link
Contributor

No description provided.

@omouraenko
Copy link
Contributor Author

Fixed #115, #120. Reverted changes to exporter as a workaround for VS Code, not sure this is a good solution.

@omouraenko omouraenko changed the title Fixed #115 Fixed #115, #120, reverted changes to exporter as a workaround for VS Code May 10, 2022
@omouraenko omouraenko closed this May 10, 2022
@omouraenko omouraenko reopened this May 10, 2022
@omouraenko
Copy link
Contributor Author

Looks like fix for #120 did not work correctly. Will take another look.

@omouraenko
Copy link
Contributor Author

omouraenko commented May 10, 2022

Second attempt seems to work for the following tests:

d =  sin(radians(90)) => \sin { \left( \operatorname{radians} 90 \right) }
d = radians(90)         => \operatorname{radians} { \left( 90 \right) }

Previous commit failed for the second test.

The initial code had the issue - 'insert_func_braces' set curly brackets before both left and right parentheses:

d =  sin(radians(90)) => \sin { \left( \operatorname{radians} 90 } \right)

Third commit just a clean up - removed extra 'return' calls.

@connorferster connorferster merged commit d329c0a into connorferster:master May 14, 2022
@connorferster
Copy link
Owner

Thank you for this contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants