This repository has been archived by the owner on Dec 24, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For any BCD feature that has a
spec_url
value: this change adds support for displaying, in the same section of the Web UI where any existing "MDN" link is displayed, a link to the relevant spec.This change also adds support for filtering feature searches based on the presence of a spec URL.
Note: It’s (unfortunately) possible for a BCD feature to be associated with multiple specs; so the
spec_url
value in BCD can be either a string or an array of strings.Therefore, to handle the possible cases, the patch in this pull request does this:
…which isn’t pretty — but the alternative of making the code handle it otherwise is bit beyond my rudimentary Rails and Postgres skills; specifically, I don’t really know how to:
But all that said, if what the existing patch is doing is just too ugly, and if I could get some guidance on how to do it better, I’d be happy to put some more time into refining this.