move babel to devDependencies #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Babel is not required for using the package, only building it, so it should not be listed as a dependency, but a devDependency.
|
@conorhastings anything preventing this? |
|
sorry have so many repos, i miss things sometimes |
|
published as 2.1.0 |
|
@conorhastings Thanks! :) @sampi Could you please remove the internal workaround since this is fixed now? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@conorhastings
Babel is not required for using the package, only building it, so it should not be listed as a dependency, but a devDependency.
We're trying to use this package in a monorepo using Yarn workspaces, and we're having issues with Babel 6 clashing with Babel 7.
This PR should fix that.