deployments: Rework to be more idiomatic jsonnet structure #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metalmatze
requested changes
Nov 6, 2019
| @@ -3,6 +3,9 @@ data: | |||
| conprof.yaml: InNjcmFwZV9jb25maWdzIjoKLSAiam9iX25hbWUiOiAiY29ucHJvZiIKICAia3ViZXJuZXRlc19zZF9jb25maWdzIjoKICAtICJuYW1lc3BhY2VzIjoKICAgICAgIm5hbWVzIjoKICAgICAgLSAiY29ucHJvZiIKICAgICJyb2xlIjogInBvZCIKICAicmVsYWJlbF9jb25maWdzIjoKICAtICJhY3Rpb24iOiAia2VlcCIKICAgICJyZWdleCI6ICJjb25wcm9mLioiCiAgICAic291cmNlX2xhYmVscyI6CiAgICAtICJfX21ldGFfa3ViZXJuZXRlc19wb2RfbmFtZSIKICAtICJzb3VyY2VfbGFiZWxzIjoKICAgIC0gIl9fbWV0YV9rdWJlcm5ldGVzX25hbWVzcGFjZSIKICAgICJ0YXJnZXRfbGFiZWwiOiAibmFtZXNwYWNlIgogIC0gInNvdXJjZV9sYWJlbHMiOgogICAgLSAiX19tZXRhX2t1YmVybmV0ZXNfcG9kX25hbWUiCiAgICAidGFyZ2V0X2xhYmVsIjogInBvZCIKICAtICJzb3VyY2VfbGFiZWxzIjoKICAgIC0gIl9fbWV0YV9rdWJlcm5ldGVzX3BvZF9jb250YWluZXJfbmFtZSIKICAgICJ0YXJnZXRfbGFiZWwiOiAiY29udGFpbmVyIgogICJzY3JhcGVfaW50ZXJ2YWwiOiAiMW0iCiAgInNjcmFwZV90aW1lb3V0IjogIjFtIg== | |||
| kind: Secret | |||
| metadata: | |||
| labels: | |||
| app.kubernetes.io/name: conprof | |||
| app.kubernetes.io/version: vv0.1.0-dev | |||
| name: conprof-main | ||
| labels: | ||
| app.kubernetes.io/name: conprof | ||
| app.kubernetes.io/version: vv0.1.0-dev |
brancz
force-pushed
the
better-jsonnet
branch
from
34b1e76
to
cfc99d9
Compare
brancz
pushed a commit
that referenced
this pull request
Oct 5, 2021
storage: Implement head.getByID to use with indexReader.LabelValueFor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks the jsonnet code to be more idiomatic, and don't work on global, but local state instead. Additionally this adds the recommended kubernetes application labels.
@metalmatze