When copying to clipboard fails, persist anyway #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Via issue #8 The previous behavior is that when copying to the clipboard fails during a rooster commands, the password would be printed but not persisted. With this change, it will be printed and persisted. Other possible approaches: * don't print the password, tell the user the operation failed * don't print the password, tell the user how they can see it if they want to (`rooster get site --show`) I included `rooster get` in these changes for consistency. I wasn't concerned about a change not being persisted, but I didn't *think* it should exit 1 if all of the other instances of clipboard error handling treat it as an acceptable circumstance. The one thing I'm wondering is whether rooster should notify the user that something went wrong during the copying so they can attempt to fix it. What do you think, Conrad?
|
@maxjacobson You are awesome ! Thanks a lot for improving Rooster ! Would you like me to add you to the contributors list in the README.md ? 😃 |
|
@maxjacobson Regarding your question about notifying the user when the clipboard copy fails, I don't know. I wouldn't mind notifying the user. But usually, this never fails. And What do you think ? |
|
@maxjacobson A new release is published and available via crates.io and |
|
Awesome, thanks! I'll chime in with some more thoughts on the new issue you created. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Via issue #8
The previous behavior is that when copying to the clipboard fails during
a rooster commands, the password would be printed but not persisted.
With this change, it will be printed and persisted.
Other possible approaches:
want to (
rooster get site --show)I included
rooster getin these changes for consistency. I wasn'tconcerned about a change not being persisted, but I didn't think it
should exit 1 if all of the other instances of clipboard error handling
treat it as an acceptable circumstance.
The one thing I'm wondering is whether rooster should notify the user
that something went wrong during the copying so they can attempt to fix
it. What do you think, Conrad?