Bug fix

consbio · Jul 19, 2018 · c843e33 · c843e33
1 parent c1307d1
commit c843e33
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,6 @@
+0.3.4 (2018-07-19)
+  * Bug fix: throw error if `addLegend` is called before control is added to the map
+
 0.3.3 (2018-07-13)
   * Add support for disabling visibility controls (see `options`)
 

diff --git a/dist/L.Control.HtmlLegend.js b/dist/L.Control.HtmlLegend.js
diff --git a/dist/L.Control.HtmlLegend.js.map b/dist/L.Control.HtmlLegend.js.map
diff --git a/index.html b/index.html
@@ -332,6 +332,7 @@
         visibleIcon: 'icon icon-eye',
         hiddenIcon: 'icon icon-eye-slash'
     })
+    map.addControl(htmlLegend1and2)
 
     htmlLegend1and2.addLegend({
         name: 'Layer 2',
@@ -346,7 +347,6 @@
             }
         }]
     })
-    map.addControl(htmlLegend1and2)
 
     var htmlLegend3 = L.control.htmllegend({
         position: 'bottomright',

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "leaflet-html-legend",
-  "version": "0.3.3",
+  "version": "0.3.4",
   "description": "Leaflet legend plugin using html elements",
   "homepage": "http://github.com/consbio/Leaflet.HtmlLegend",
   "author": {

diff --git a/src/L.Control.HtmlLegend.js b/src/L.Control.HtmlLegend.js
@@ -51,7 +51,9 @@ L.Control.HtmlLegend = L.Control.extend({
     addLegend(legend) {
         if (this._map) {
             this._renderLegend(legend);
+            return this._lastId;
         }
+        throw Error('Legend control must be added to the map first.')
     },
 
     removeLegend(itemIdx) {