ENH: Log errors to logger in addition to raising exceptions #108
Conversation
| throw new Error(`Could not normalize Mapbox source URL: ${url}\n${e}`) | ||
| const msg = `Could not normalize Mapbox source URL: ${url}\n${e}` | ||
| logger.error(msg) | ||
| throw new Error(msg) |
There was a problem hiding this comment.
I assume there's no simple way to catch and log errors at a higher level?
There was a problem hiding this comment.
Yes and no. Commit 42184b3 fixed the error logging at the server level (server must be started in verbose mode via -v); previously it was it was not passing back the string error message correctly. Fixing this allowed us to reduce the double-logging in the server tier.
Within the renderer it is a bit of a different story: there are some things that we can propagate back up via exception handling (by throwing errors) whereas in other places these are outside the main control flow. For example, we cannot raise exceptions based on style parsing error messages / warnings passed back by maplibre, since these happen outside the normal control flow (this is a known issue).
I did remove some of the unnecessary log statements from renderer related to validating inputs; those are already validated in the server tier, and when using the NodeJS API directly it is OK for those to simply raise errors.
Previously, most errors were not logged to the logger (server-side) and instead only returned in the response to the client, which made it difficult to debug when the errors were ultimately related to the server (e.g., missing an expected tileset)