Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/front end data renaming #376

Merged
merged 9 commits into from
Jul 19, 2023
Merged

Conversation

DemogorGod
Copy link
Contributor

Hey guys, just changed some of the front-end stuff to match with the requested stuff on the table side and staking component side as well. my commits basically describe everything I did. Let me know if any other changes are needed and I will adjust them in future prs. Enjoy the video!

@elizyoung0011 currently the links on the table do not connect to any external websites ( I believe I was told not to do it before ) so if you want to confirm that, that is the intended user flow on our website is to take users onto other websites and not create modals/pop ups that shows the information that other websites have, then I can do that for sure. I will also need a format on how to connect to those sites using a specific tx hash or other variables. Thanks!!

@ccali11 There are some spots on the fe that require a method that fetches the current staked total by wallet address if you can just create me a method on the backend in one of your composables for me i can connect it to all of the places that it is needed. Thanks!!

Screen.Recording.2023-07-18.at.10.01.51.PM.mov

@DemogorGod DemogorGod requested review from a team, ccali11, shanejearley and hawyar and removed request for a team July 19, 2023 02:13
@shanejearley
Copy link
Contributor

@DemogorGod the links would be invalid until testnet launch anyways, so you can put that off for this PR.

Copy link
Contributor

@shanejearley shanejearley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DemogorGod Perfect changes.
@elizyoung0011 Time to add tooltips? Could make an issue if you want Steve to start that.

@elizyoung0011
Copy link

Yep- I’ll creat a tooltip issue with text.

@DemogorGod DemogorGod merged commit 279d627 into develop Jul 19, 2023
1 check passed
@DemogorGod DemogorGod deleted the feature/front-end-data-renaming branch July 19, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants