Feat/plonk generic #250
Merged
Feat/plonk generic #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbotrel
requested changes
May 26, 2022
There was a problem hiding this comment.
couple cosmetic changes / dead code;
also, would make sense in a separate PR to think API wise how a end-user selects between
"PLONK[KZG]" "PLONKFRI" + custom gates when they come through.
Maybe just one expose "plonk" and some options to pick the correct instantiation
| // | ||
| // it's underlying implementation is curve specific (see gnark/internal/backend) | ||
| type Proof interface { | ||
| // io.WriterTo |
There was a problem hiding this comment.
serialization is not implemented for proof / pk / vk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PLONK scheme is now instantiated with FRI. The protocol in itself is adapted for non homomorphic polynomial commitment scheme.
It's just the unrolled protocol, with batching of commitments, so the scheme is a naive sequence of commitments + openings, along with the algebraic relations checks.