Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/plonk generic #250

Merged
merged 37 commits into from
Jul 14, 2022
Merged

Feat/plonk generic #250

merged 37 commits into from
Jul 14, 2022

Conversation

ThomasPiellard
Copy link
Collaborator

@ThomasPiellard ThomasPiellard commented Feb 3, 2022

The PLONK scheme is now instantiated with FRI. The protocol in itself is adapted for non homomorphic polynomial commitment scheme.

It's just the unrolled protocol, with batching of commitments, so the scheme is a naive sequence of commitments + openings, along with the algebraic relations checks.

@ThomasPiellard ThomasPiellard marked this pull request as draft February 3, 2022 14:51
@ThomasPiellard ThomasPiellard marked this pull request as ready for review April 13, 2022 12:34
Copy link
Collaborator

@gbotrel gbotrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple cosmetic changes / dead code;
also, would make sense in a separate PR to think API wise how a end-user selects between
"PLONK[KZG]" "PLONKFRI" + custom gates when they come through.

Maybe just one expose "plonk" and some options to pick the correct instantiation

//
// it's underlying implementation is curve specific (see gnark/internal/backend)
type Proof interface {
// io.WriterTo
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

serialization is not implemented for proof / pk / vk

backend/plonkfri/plonkfri.go Outdated Show resolved Hide resolved
integration_test.go Show resolved Hide resolved
integration_test.go Outdated Show resolved Hide resolved
internal/backend/bls12-377/plonkfri/prove.go Show resolved Hide resolved
internal/backend/bls12-377/plonkfri/prove.go Outdated Show resolved Hide resolved
internal/backend/bls12-377/plonkfri/setup.go Show resolved Hide resolved
internal/backend/bls12-377/plonkfri/verify.go Outdated Show resolved Hide resolved
internal/backend/bls12-377/plonkfri/verify.go Outdated Show resolved Hide resolved
test/assert.go Show resolved Hide resolved
@gbotrel gbotrel merged commit 31bc701 into develop Jul 14, 2022
@gbotrel gbotrel deleted the feat/plonk_generic branch July 14, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants