Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: misspelled ("decsribes" -> "describes") #339

Merged
merged 2 commits into from Jul 29, 2022

Conversation

tinywell
Copy link
Contributor

fix misspelled word decsribes to describes in the comment of struct R1CS

@gbotrel
Copy link
Collaborator

gbotrel commented Jul 27, 2022

hey, thanks for the contrib, can you modify the r1cs.go.tmpl file and run go generate ./... on your PR?

@tinywell
Copy link
Contributor Author

hey, thanks for the contrib, can you modify the r1cs.go.tmpl file and run go generate ./... on your PR?

Sorry, I'm new to the project and I didn't realize this file was auto-generated from the template. I will modify as you said.
Thanks for your guide.

@gbotrel gbotrel merged commit 8bc13b2 into Consensys:master Jul 29, 2022
gbotrel added a commit that referenced this pull request Jul 29, 2022
gbotrel added a commit that referenced this pull request Sep 14, 2022
* fix: misspelled ("decsribes" ->  "describes") (#339)

* fix  misspelled ("decsribes" ->  "describes")

* fix  misspelled ("decsribes" ->  "describes") from tmpl file and regenerate

Co-authored-by: tinywell <tinywell@tinywell.com>

* add plonk verifier: support single proof verification

* remove unused variable in solidity

* build: re-ran go generate

* docs: add un-audited warning in plonk solidity

* feat: change solidity ver for plonk

* feat: factorize serailization test in plonk

* feat: added writeRaw for plonk proof

* feat: added io.WriterRawTo to plonk.Proof

* fix: change loop condition to avoid revert with solc

* docs: updated ExportSolidity docs

Co-authored-by: tinywell <zfh-zyw@163.com>
Co-authored-by: tinywell <tinywell@tinywell.com>
Co-authored-by: ryan <lightningli0504@gmail.com>
gbotrel added a commit that referenced this pull request Sep 15, 2022
* fix: misspelled ("decsribes" ->  "describes") (#339)

* fix  misspelled ("decsribes" ->  "describes")

* fix  misspelled ("decsribes" ->  "describes") from tmpl file and regenerate

Co-authored-by: tinywell <tinywell@tinywell.com>

* Fix Or && Xor

Co-authored-by: tinywell <zfh-zyw@163.com>
Co-authored-by: tinywell <tinywell@tinywell.com>
Co-authored-by: Gautam Botrel <gautam.botrel@gmail.com>
gbotrel pushed a commit that referenced this pull request Oct 6, 2022
* fix: misspelled ("decsribes" ->  "describes") (#339)

* fix  misspelled ("decsribes" ->  "describes")

* fix  misspelled ("decsribes" ->  "describes") from tmpl file and regenerate

Co-authored-by: tinywell <tinywell@tinywell.com>

* Fix: minor typo (#360)

Fix: minor typo

* Use shared array for input

* Fixes in the template

Co-authored-by: tinywell <zfh-zyw@163.com>
Co-authored-by: tinywell <tinywell@tinywell.com>
Co-authored-by: omahs <73983677+omahs@users.noreply.github.com>
AlexandreBelling pushed a commit to AlexandreBelling/gnark that referenced this pull request Nov 24, 2022
* fix: misspelled ("decsribes" ->  "describes") (Consensys#339)

* fix  misspelled ("decsribes" ->  "describes")

* fix  misspelled ("decsribes" ->  "describes") from tmpl file and regenerate

Co-authored-by: tinywell <tinywell@tinywell.com>

* Fix: minor typo (Consensys#360)

Fix: minor typo

* Use shared array for input

* Fixes in the template

Co-authored-by: tinywell <zfh-zyw@163.com>
Co-authored-by: tinywell <tinywell@tinywell.com>
Co-authored-by: omahs <73983677+omahs@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants