Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup std/math/emulated #448

Closed
gbotrel opened this issue Jan 25, 2023 · 0 comments
Closed

cleanup std/math/emulated #448

gbotrel opened this issue Jan 25, 2023 · 0 comments
Labels
cleanup
Milestone
v0.8.0

Comments

@gbotrel
Copy link
Collaborator

gbotrel commented Jan 25, 2023

Before focusing on "plonk-specific" optimizations in the package, would like to reduce its scope. For example the implementation of frontend.Builder and frontend.API may not be strictly necessary, since using emulated.Element directly seems to be more convenient in all use cases so far.
@gbotrel gbotrel added this to the v0.8.0 milestone Jan 25, 2023
gbotrel added a commit that referenced this issue Jan 27, 2023
@gbotrel
refactor: emulated clean up fixes #448 (#449)
3f4cefa 
* refactor: step 1 clean up api and builder wrapper

* refactor: PackElementLimbs PackFull -> packLimbs

* refactor: added field.NewElement

* refactor: remove deadcode from builder stuff, update stats with constraining inputs

* build: restore golangci-lint conf

* refactor: emulated.NewConstant -> emulated.FromConstant

* refactor: emulated.FromConstant -> emulated.ValueOf

* fix: ensure we alwways constrain witness limbs

* fix: fix optimisation test bound with constrained limbs

* perf: constraint to modulus width the witness limbs
@gbotrel gbotrel closed this as completed Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup
Projects
None yet
Milestone
v0.8.0
Development

No branches or pull requests
1 participant
@gbotrel