Further documentation improvements #119
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is consistent with e.g. PEP-257. Before, the doc comments were inconsistent on this matter.
… too large argument.
|
Oops, wrong branch. Will re-open with the right commits. |
|
Actually, no: I thought I had already submitted this, but it turns out I never did. Oh well --- here you are. |
The implementation is a proof-of-concept, and now fully polished yet.
Instead, check the number of rows above the cursor position, and error if passed a too large number.
|
Needs correction. |
benesch
pushed a commit
to benesch/console
that referenced
this pull request
Dec 4, 2022
This PR adds a `retain-for` duration argument to the console. Additionally, I have modified the proto to not include the total_time for tasks,resources and async ops and instead contain `created_at` and `dropped_at` fields. A separate `console-util` crate has been added that contains the logic for parsing a duration string. Close console-rs#108 Signed-off-by: Zahari Dichev <zaharidichev@gmail.com> Co-authored-by: Eliza Weisman <eliza@buoyant.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a few further improvements to the doc comments, similar in spirit to #110.
I don't know how to get rid of the merge commit (github added that for me). Feel free to rebase for me and remove it.