Fix clear_screen/clear_line on Windows #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitsuhiko
approved these changes
Jan 25, 2020
|
Thanks! |
|
Thank you for your quick response! |
Archina
pushed a commit
to Archina/console
that referenced
this pull request
Apr 5, 2021
Archina
pushed a commit
to Archina/console
that referenced
this pull request
Apr 5, 2021
dtolnay
pushed a commit
to dtolnay-contrib/console
that referenced
this pull request
Feb 4, 2022
this branch builds on console-rs#44 and adds waker stats to the console's task view. i also rearranged the task view a bit to make it a little more readable. now, stats are grouped into boxes, and the fields are drawn on multiple lines (which will be nice if we start recording user fields...). for example:  also, i refactored a few things. Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On windows,
clear_screendoes not clear attributes like underline.dalance/procs#34
This PR adds
FillConsoleOutputAttributeto clear attributes as the same as https://docs.microsoft.com/en-us/windows/console/clearing-the-screen.