Add VT100 character set sequences to STRIP_ANSI_RE #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pksunkara
approved these changes
Mar 23, 2021
dtolnay
pushed a commit
to dtolnay-contrib/console
that referenced
this pull request
Feb 4, 2022
It was noted that emitting a tracing event inside the subscriber could trigger a deadlock, since `std::sync::Once` is not re-entrant. This removes the tracing from the subscriber `Layer` methods. If the capacity was full, sending the event was spawned into tokio, but the event might not have been inside a runtime in the first place. And it essentially turns it into an unbounded queue. So that is also removed. It also changes from using a constant `FLUSH_AT_CAPACITY` to a struct field that is based on the configured event buffer capacity. A value of half the buffer capacity was chosen, since hitting a full channel will now mean the event is completely lost. Closes console-rs#27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for stripping/iterating a couple VT100 escape sequences alongside the ANSI ones.
While VT100 isn't technically ANSI, most modern terminals still implement a subset of them. The changes specifically add support for the sequences responsible for switching between the box-drawing and regular character sets.