New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ColorfulTheme's MultiSelect basically can't be used with an empty environment #114
Comments
Actually I found a bypass myself: using This being said… I wonder whether this should not be done upstream? If only so that people with screenreaders (who… hopefully can use the SimpleTheme? I'm not sure) could use programs made by people who didn't think of this case and just used ColorfulTheme without giving it a second thought. |
The colors are switched on if a TTY is found. I am not exactly sure what happened with I think the best solution here is to edit the rendering of multi-select in ColorfulTheme. |
I'd guess the reason why This being said, your proposed solution does sound great to me too :) |
this fixes console-rs#114 and also improves accessability related to console-rs#149
For reasons that are yet unclear to me, ColorfulTheme becomes monochrome when being used with an empty environment (
env -i [binary]
).This, in turn, makes its
MultiSelect
, that exclusively relies on colors to identify which items are selected, unusable.Would it make sense to have ColorfulTheme automatically detect when it's being used in a way that will make colors not work, and have it fall back to SimpleTheme? If not, how would you suggest one to handle this scenario?
Anyway, thank you for indicatif and dialoguer, they're both awesome crates :)
The text was updated successfully, but these errors were encountered: