Unwrap ProgressFinish #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR -- can you explain why you think these changes represent an improvement? I like that we no longer need
And also, would you mind going over your other open PRs to see if they are still relevant/useful? |
Preserves the historical behavior
|
I'm working on #192, probably will update today, and #132 will be obsolete once I finish another PR, no eta on it though. #256 I have currently postponed and will do some refactoring before returning to it.
|
djc
reviewed
Apr 16, 2021
src/style.rs
Outdated
| @@ -15,14 +15,14 @@ use unicode_segmentation::UnicodeSegmentation; | |||
| pub enum ProgressFinish { | |||
| /// Finishes the progress bar and leaves the current message. | |||
| /// Same behavior as calling [`ProgressBar::finish()`]. | |||
| Default, | |||
| Finish, | |||
There was a problem hiding this comment.
I think it would be clearer if we call this AndLeave, what do you think?
There was a problem hiding this comment.
Sounds good, it's more consistent with the rest, changed it
aj-bagwell
pushed a commit
to aj-bagwell/indicatif
that referenced
this pull request
May 20, 2021
* Unwrap ProgressFinish * Change ProgressFinish::default to _::AndClear Preserves the historical behavior * Rename `ProgressFinish::Finish` to `_::AndLeave`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes default behavior - now a progress bar without an explicitly set on_finish will call
finish, when previously it would callfinish_and_clear(src/style.rs:103). Also,on_finishwon't be reset every timefinish_with_styleis called.