Revert heuristic algorythm #620
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hting" This reverts commit 011c998.
|
I'm not interested in reverting this until we have better research showing that this is the best solution. Otherwise we're just stuck trading one person's use cases off against another's, which doesn't seem like an improvement. |
|
I haven't really had time to look at issues for this project, but I want to add that my PR fixed some pretty significant issues with the old approach. If for some reason the approach was found wanting, the appropriate solution would involve fixing the bugs in the previous algorithm and not just blindly reverting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert ETA heuristics, untill better solution found.
Current version produce large ETA results when cycle time is greater than 15s.
This reverts commit 011c998.