Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make table headers optional when table is empty #108

Merged
merged 3 commits into from
Mar 30, 2024

Conversation

greg-1-anderson
Copy link
Member

@greg-1-anderson greg-1-anderson commented Jun 7, 2023

Overview

This pull request:

  • Fixes a bug
  • Adds a feature
  • Breaks backwards compatibility
  • Has tests that cover changes

Summary

Add TABLE_EMPTY_MESSAGE formatter option to allow caller to control whether or not table headers should be emitted when the table is empty.

…hether or not table headers should be emitted when the table is empty
@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.97%. Comparing base (f65524e) to head (d2557c1).
Report is 3 commits behind head on 4.x.

Additional details and impacted files
@@             Coverage Diff              @@
##                4.x     #108      +/-   ##
============================================
+ Coverage     91.94%   91.97%   +0.03%     
- Complexity      525      534       +9     
============================================
  Files            50       50              
  Lines          1316     1334      +18     
============================================
+ Hits           1210     1227      +17     
- Misses          106      107       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tests/FormattersTest.php Outdated Show resolved Hide resolved
Co-authored-by: Moshe Weitzman <weitzman@tejasa.com>
@greg-1-anderson greg-1-anderson merged commit 1fc3d75 into 4.x Mar 30, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants