Task assembly

composer.json

@@ -21,7 +21,7 @@
         "symfony/console": "~2.5|~3.0",
         "symfony/process": "~2.5|~3.0",
         "symfony/filesystem": "~2.5|~3.0",
-        "symfony/dependency-injection": "~2.5|~3.0"
+        "league/container": "~2"
     },
     "require-dev": {
         "patchwork/jsqueeze": "~1.0",

src/Application.php

@@ -9,14 +9,70 @@
 
 class Application extends  SymfonyApplication
 {
+    /**
+     * @var \Robo\TaskAssembler
+     */
+    protected $taskAssembler;
+
+    public function __construct($name, $version)
+    {
+        parent::__construct($name, $version);
+
+        $this->getDefinition()->addOption(
+            new InputOption('--simulate', null, InputOption::VALUE_NONE, 'Run in simulated mode (show what would have happened).')
+        );
+    }
+
+    public function setTaskAssembler($taskAssembler)
+    {
+        $this->taskAssembler = $taskAssembler;
+    }
+
+    public function taskAssembler()
+    {
+        return $this->taskAssembler;
+    }
+
+    protected static function findAccessorMethods($commandNames)
+    {
+        $accessorNames = [];
+        // Using get_class_vars is not reliable, because it only
+        // exposes public class variables.
+        foreach ($commandNames as $commandName) {
+            // We count a set of methods as accessor methods if
+            // there is a setter and at least one getter.
+            if (strpos($commandName, 'set') === 0) {
+                $name = lcfirst(substr($commandName, 3));
+                $getter = 'get' . ucfirst($name);
+                $hasGetter = false;
+                if (in_array($name, $commandNames)) {
+                    $accessorNames[] = $name;
+                    $hasGetter = true;
+                }
+                if (in_array($getter, $commandNames)) {
+                    $accessorNames[] = $getter;
+                    $hasGetter = true;
+                }
+                if ($hasGetter) {
+                    $accessorNames[] = $commandName;
+                }
+            }
+        }
+        return $accessorNames;
+    }
 
     public function addCommandsFromClass($className, $passThrough = null)
     {
         $roboTasks = new $className;
+        if ($roboTasks instanceof \Robo\Tasks) {
+            $roboTasks->setTaskAssembler($this->taskAssembler);
+        }
 
-        $commandNames = array_filter(get_class_methods($className), function($m) {
+        $commandNames = array_filter(get_class_methods($className), function ($m) {
             return !in_array($m, ['__construct']);
         });
+        $accessorNames = static::findAccessorMethods($commandNames);
+        $commandNames = array_diff($commandNames, $accessorNames);
 
         foreach ($commandNames as $commandName) {
             $command = $this->createCommand(new TaskInfo($className, $commandName));
@@ -28,6 +84,11 @@ public function addCommandsFromClass($className, $passThrough = null)
                     $args[key(array_slice($args, -1, 1, TRUE))] = $passThrough;
                 }
                 $args[] = $input->getOptions();
+                // Need a better way to handle global options
+                // Also, this is not necessarily the best place to do this
+                Config::setGlobalOptions($input);
+                // Avoid making taskAssembler depend on Config class.
+                Config::service('taskAssembler')->setSimulated(Config::isSimulated());
 
                 $res = call_user_func_array([$roboTasks, $commandName], $args);
                 if (is_int($res)) exit($res);
@@ -97,4 +158,4 @@ public function addInitRoboFileCommand($roboFile, $roboClass)
         });
         $this->add($createRoboFile);
     }
-}
+}

src/Common/TaskIO.php

@@ -14,6 +14,21 @@
  */
 trait TaskIO
 {
+    /**
+     * @var \Psr\Log\LoggerInterface
+     */
+    protected $logger;
+
+    public function setLogger($logger)
+    {
+        $this->logger = $logger;
+    }
+
+    public function logger()
+    {
+        return $this->logger ?: Config::logger();
+    }
+
     /**
      * Print information about a task in progress.
      *
@@ -31,7 +46,7 @@ protected function printTaskInfo($text, $context = null)
         // The 'note' style is used for both 'notice' and 'info' log levels;
         // However, 'notice' is printed at VERBOSITY_NORMAL, whereas 'info'
         // is only printed at VERBOSITY_VERBOSE.
-        Config::logger()->notice($text, $this->getTaskContext($context));
+        $this->logger()->notice($text, $this->getTaskContext($context));
     }
 
     /**
@@ -48,7 +63,7 @@ protected function printTaskSuccess($text, $context = null)
         // override in the context so that this message will be
         // logged as SUCCESS if that log level is recognized.
         $context['_level'] = ConsoleLogLevel::SUCCESS;
-        Config::logger()->notice($text, $this->getTaskContext($context));
+        $this->logger()->notice($text, $this->getTaskContext($context));
     }
 
     /**
@@ -59,7 +74,7 @@ protected function printTaskSuccess($text, $context = null)
      */
     protected function printTaskWarning($text, $context = null)
     {
-        Config::logger()->warning($text, $this->getTaskContext($context));
+        $this->logger()->warning($text, $this->getTaskContext($context));
     }
 
     /**
@@ -70,7 +85,7 @@ protected function printTaskWarning($text, $context = null)
      */
     protected function printTaskError($text, $context = null)
     {
-        Config::logger()->error($text, $this->getTaskContext($context));
+        $this->logger()->error($text, $this->getTaskContext($context));
     }
 
     /**
@@ -79,7 +94,7 @@ protected function printTaskError($text, $context = null)
      */
     protected function printTaskDebug($text, $context = null)
     {
-        Config::logger()->debug($text, $this->getTaskContext($context));
+        $this->logger()->debug($text, $this->getTaskContext($context));
     }
 
     /**