Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #483: Update dependencies for php 5.5 during composer install #486

Merged
merged 4 commits into from
Nov 10, 2016

Conversation

greg-1-anderson
Copy link
Member

Overview

This pull request:

  • Fixes a bug
  • Adds a feature
  • Breaks backwards compatibility
  • Needs tests

Description

Allows composer install to work out-of-the-box with php 5.5. Detects a composer.lock file containing incompatible dependencies, and fixes up the composer.json require-dev section as needed.

n.b. Simply removing composer.lock does not do the trick. Seems like it should, but it doesn't.

As a bonus, this PR also adds highest / lowest dependency checking to Robo tests.

@coveralls
Copy link

coveralls commented Nov 10, 2016

Coverage Status

Coverage decreased (-0.2%) to 58.362% when pulling b9327a9 on php-55-checks into 3530d52 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 58.362% when pulling b9327a9 on php-55-checks into 3530d52 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 58.362% when pulling b9327a9 on php-55-checks into 3530d52 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 58.526% when pulling b9327a9 on php-55-checks into 3530d52 on master.

@coveralls
Copy link

coveralls commented Nov 10, 2016

Coverage Status

Coverage remained the same at 58.526% when pulling 3ed19c7 on php-55-checks into 3530d52 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.008%) to 58.535% when pulling adf3893 on php-55-checks into 3530d52 on master.

1 similar comment
@coveralls
Copy link

coveralls commented Nov 10, 2016

Coverage Status

Coverage increased (+0.008%) to 58.535% when pulling adf3893 on php-55-checks into 3530d52 on master.

@greg-1-anderson greg-1-anderson merged commit 554943d into master Nov 10, 2016
@greg-1-anderson greg-1-anderson deleted the php-55-checks branch November 10, 2016 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants