Ensure that php code sniffer is not included in robo.phar. Allow Rsyn… #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c::fromPath() to take an array of paths, and make phar:build rsync using a whitelist instead of a blacklist.
Nitpick-CI
reviewed
Nov 15, 2016
| ->toPath('/var/path/with/a space') | ||
| ->getCommand() | ||
| )->equals( | ||
| 'rsync src/foo src/bar \'dev@localhost:/var/path/with/a space\'' |
There was a problem hiding this comment.
Multi-line function call not indented correctly; expected 12 spaces but found 16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request:
Summary
Ensure that size of phar remains reasonable (2.2M needed, rather than >4M)
Description
The php code sniffer was being included in the phar. This PR fixes that, and also improves the Rsync task so that the phar:build command can copy via a whitelist instead of a blacklist.