Remove unnecessary string formatting for sshCommand #626
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request:
Summary
SshCommand is using sprintf to return a formatted command, but it's not actually sing any variables and basically just relies on inline variable interpolation. I think it is redundant and it's creating some other issues with string formatting, as now you have to escape your % characters in your options.
Description
Please see the following usage scenario:
If you use sprintf, you will have to escape all % chars with another %. But since sprintf is not doing any formatting now, I propose to replace it with string interpolation.
Possible breaking change:
This may be a breaking change for someone who already relied on sshCommand and was already escaping the '%' character, they may end up with
%%
in their custom code