Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for documenting traits #668

Merged
merged 1 commit into from Jan 10, 2018
Merged

Added support for documenting traits #668

merged 1 commit into from Jan 10, 2018

Conversation

DavertMik
Copy link
Member

@DavertMik DavertMik commented Jan 9, 2018 •
edited

Overview

This pull request:

  • Fixes a bug
  • Adds a feature
  • Breaks backwards compatibility
  • Has tests that cover changes

Summary

Added support for documenting traits in GenMarkdown task

greg-1-anderson
greg-1-anderson approved these changes Jan 9, 2018
View reviewed changes
Copy link
Member

@greg-1-anderson greg-1-anderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome LGTM

@DavertMik DavertMik merged commit d7606cc into master Jan 10, 2018
@DavertMik DavertMik deleted the DavertMik-patch-1 branch January 10, 2018 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg-1-anderson greg-1-anderson greg-1-anderson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DavertMik @greg-1-anderson