ImageMinify: Prevent undefined variable error #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the given imagefile is not one of the defaults (png/jpg/gif/svg) and no minifier was passed to the ImageMinify task a warning for an undefined variable is show. Prevent this by setting an empty string to the beginning of the file check. Refs consolidation#852
|
Thanks. A second PR would be helpful, as I wouldn't forget to cherry-pick this later if you did that. |
4 tasks
pixelbrackets
changed the title
pixelbrackets
changed the title
|
Thanks for the fast merges! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the given imagefile is not one of the defaults (png/jpg/gif/svg) and no minifier was passed to the ImageMinify task a warning for an undefined variable is show.
Prevent this by setting an empty string to the beginning of the file check.
Refs #852
Overview
This pull request:
Summary
Adds an empty variable string to the beginning of the loop to check for matching minifiers. This will prevent trying to access a non existing variable later on.
Note
This bugfix is for the master (Development version 2.x).
It may also be cherry-picked to the
1.xbranch as well (I could send a second PR as well).