Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a limit to replace via regexp #946

Merged
merged 1 commit into from
May 22, 2020
Merged

Add a limit to replace via regexp #946

merged 1 commit into from
May 22, 2020

Conversation

davidsneighbour
Copy link
Contributor

@davidsneighbour davidsneighbour commented May 12, 2020

Overview

This pull request:

  • Fixes a bug
  • Adds a feature
  • Breaks backwards compatibility
  • Has tests that cover changes
  • Adds or fixes documentation

Summary

When using Replace with Regexp there is no possibility to add a limit to the replaced items. This would be useful for instance when I replace version numbers in the DocBlock of fields and we want to replace only a single occurence.

for #945

When using [Replace with Regexp](https://robo.li/tasks/File/#replace) there is no possibility to add a limit to the replaced items. This would be useful for instance when I replace version numbers in the DocBlock of fields and we want to replace only a single occurence.

for #123
@davidsneighbour
Copy link
Contributor Author

Tests and Documentation changes (if any are required) are missing from this.

@greg-1-anderson greg-1-anderson merged commit 30e78de into consolidation:master May 22, 2020
@davidsneighbour davidsneighbour deleted the davidsneighbour-patch-1 branch May 27, 2020 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants