Allow to reset the timer #997
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems okay. We are no longer using the |
* [FEATURE] Add SemVer unit test * [BUGFIX] Remove redundant check preventing file writes Remove the check that a given filename is writetable, since this requires the file to exist beforehand. We dont expect the file to exist however. Therefore this check should not be made or create a file if failing. Since this check is included in file_put_contents anyway we may remove the check safely. Closes #959
* Add ignorelist to pack command. * Add documentation. * Normalize pattern, use only regex without enclosing slashes.
* Use inject-input-output PR from consolidation/annotated-commands * Only invalidate the SymfonyStyle object when the input or output object change. * Use annotated-command ^4.2
…ts (#968) * Robo-947: Add function for retrieving an application to be used with tests. * Fix nits. Drupal does not dictate all code styles. * Fix the nit. * Don't invoke getRoboFileCommands unnecessarily. * Nitpicks. * Test try:exec to validate status codes. * Nitpicks. * Add references to usage of test app getter. * Don't use a trait in Runner from the tests dir. * Try disabling interactivity. * Revert "Try disabling interactivity." This reverts commit 46a727b. * Use null coalescence. * Remove incorrect commentary. * Mark test as skipped for lowest dependency check for symfony4.
* Update lowest dependency and remove skip from test. * Correct the "lowest" configuration for Symfony4
…r objects in class fields.
…ange Robo styling at this point. Update the getting started guide.
…h when "printOutput(false)" is called. (#977)
…ded "printOutput()" instead. (#980)
* Fix #935: Upgrade to League Container 3.x * League\Container\ContainerAwareTrait::getContainer() uses execeptions now. * Use Psr\Container\ContainerInterface. * Restored return types on Robo::createContainer() / Robo::createDefaultContainer() and param type on Robo::finalizeContainer(). * Reverted changes to Robo::createContainer() and Robo::createDefaultContainer() return types. Co-authored-by: Dane Powell <git@danepowell.com>
…s. (#987) * Avoid public methods from Robo\Common\IO to be interpreted as commands. * Add a CommandInfoAlterer to ignore methods. * Use the IgnoredCommandsRegexp facility from AnnotatedCommand to remove methods. * Set minimum required annotated-command version. * Pass excluded files as expected by pear/archive_tar.
Nitpick-CI
reviewed
Oct 20, 2020
| @@ -10,15 +12,15 @@ class RoboFile extends \Robo\Tasks | |||
| * to run the tests. This command also runs the remaining Codeception | |||
| * tests. You must re-add Codeception to the project to use this. | |||
| */ | |||
| public function test(array $args, $options = | |||
| public function test(ConsoleIO $io, array $args, $options = | |||
There was a problem hiding this comment.
- The first parameter of a multi-line function declaration must be on the line after the opening bracket
- Multi-line function declarations must define one parameter per line
Nitpick-CI
reviewed
Oct 20, 2020
| [ | ||
| 'coverage-html' => false, | ||
| 'coverage' => false | ||
| ]) | ||
| { | ||
| $this->yell("Deprecated: use 'composer test' instead."); | ||
| $io->warning("Deprecated: use 'composer test' instead. Codeception-based tests will fail."); |
There was a problem hiding this comment.
Line indented incorrectly; expected at least 12 spaces, found 8
Nitpick-CI
reviewed
Oct 20, 2020
|
|
||
| $collection = $this->collectionBuilder(); | ||
| $collection = $this->collectionBuilder($io); |
There was a problem hiding this comment.
Line indented incorrectly; expected at least 12 spaces, found 8
Nitpick-CI
reviewed
Oct 20, 2020
| @@ -17,6 +21,59 @@ trait IO | |||
| */ | |||
| protected $io; | |||
|
|
|||
| public function currentState() | |||
| { | |||
| return new class($this, $this->input, $this->output, $this->io) implements State { | |||
There was a problem hiding this comment.
- Class name
($this,is not in camel caps format - Expected 1 space before
output; 2 found - Expected 1 space before
io; 2 found - Expected 0 spaces between
ioand comma; 1 found - Opening brace of a class must be on the line after the definition
Nitpick-CI
reviewed
Oct 20, 2020
| { | ||
| $this->obj->restoreState($this->input, $this->output, $this->io); | ||
| } | ||
| }; |
There was a problem hiding this comment.
Closing class brace must be on a line by itself
|
Okay, I'll create a new PR 🤦 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request:
Summary
This change allows to reset the timer.
Description
Starting, stopping, and then starting the timer again works like pause/resume feature. However, there are cases when I need to reset the timer to measure the time it takes to complete each step.