Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SelfUpdateCommand should not expect package version to be ready for normalization #26

Open
Chi-teck opened this issue Dec 12, 2023 · 0 comments

Comments

@Chi-teck
Copy link

Some projects use version as a placeholder that is dynamically updated when PHAR file is built.

Example:
gordalina/cachetool#231

I think the current implementation should be updated to something like follows.

try {
  $this->currentVersion = $version_parser->normalize($currentVersion);
}
catch (UnexpectedValueException) {
  $this->currentVersion = 'Unknown';
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant