Fix #29: Drop support for Symfony 4 and PHP 7 #30
+219
−147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrodala
reviewed
Jan 22, 2024
|
I'm not sure why tests are failing. Exit code 255 and not much else to go on. I may need to circle back to this later if I have time. @greg-1-anderson maybe you can take a look? Also, you'll need to merge this fixture update regardless: consolidation/self-update-fixture#3 |
danepowell
commented
Jan 23, 2024
| @@ -18,9 +18,9 @@ jobs: | |||
| - name: Checkout self-update-fixtures | |||
| uses: actions/checkout@v2 | |||
| with: | |||
| repository: consolidation/self-update-fixture | |||
| repository: danepowell/self-update-fixture | |||
There was a problem hiding this comment.
Todo, switch this back to the consolidation origin and self-update branch once consolidation/self-update-fixture#3 is merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29
To be reviewed in conjunction with #28