fix: Shell object is not an array

consolidation · Feb 3, 2022 · cc07d0f · cc07d0f
1 parent e9d0f02
commit cc07d0f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/Transport/CustomTransport.php b/src/Transport/CustomTransport.php
@@ -35,13 +35,14 @@ public function configure(SiteProcess $process)
      */
     public function wrap($args)
     {
-        $transport = Shell::preEscaped($this->siteAlias->get('custom.command', ''));
+        $cmd = $this->siteAlias->get('custom.command', '');
+        $transport = $cmd ? [Shell::preEscaped($cmd)] : [];
         $commandToExecute = $this->getCommandToExecute($args);
 
-        return array_merge(
+        return array_filter(array_merge(
             $transport,
             $commandToExecute
-        );
+        ));
     }
 
     /**

diff --git a/tests/Transport/CustomTransportTest.php b/tests/Transport/CustomTransportTest.php
@@ -47,8 +47,8 @@ public function wrapTestValues()
     public function testWrap($expected, $siteAliasData)
     {
         $siteAlias = new SiteAlias($siteAliasData, '@alias.dev');
-        $dockerTransport = new CustomTransport($siteAlias);
-        $actual = $dockerTransport->wrap(['ls']);
+        $customTransport = new CustomTransport($siteAlias);
+        $actual = $customTransport->wrap(['ls']);
         $this->assertEquals($expected, implode(' ', $actual));
     }
 }