Add custom transport to allow wrapping with any command #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
| public function check(SiteAliasInterface $siteAlias) | ||
| { | ||
| return $siteAlias->has('command'); |
There was a problem hiding this comment.
@greg-1-anderson, I agree. I hesitated to put it in but on thinking more, it started making sense as the functionality is really that generic. That said, I am open to alternatives.
Codecov Report
@@ Coverage Diff @@
## main #61 +/- ##
============================================
- Coverage 78.41% 78.19% -0.23%
- Complexity 164 172 +8
============================================
Files 18 20 +2
Lines 417 431 +14
============================================
+ Hits 327 337 +10
- Misses 90 94 +4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request:
Summary
This adds a new option to site aliases which lets users specify any command to wrap invoked processes (such as drush).
Description
More details in #52.