Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WordPress core does not contain a wp-config.php file; do not require … #1

Merged
merged 1 commit into from Dec 12, 2018

Conversation

greg-1-anderson
Copy link
Member

…that file to be present when detecting WordPress installs.

Overview

This pull request:

Q A
Bug fix? yes
New feature? no
Has tests? yes
BC breaks? no
Deprecations? no

Summary

Previously we depended on having a wp-config.php file in the WordPress root. This file is required to run, but is not shipped as part of the repository in WordPress core. We want to be able to detect uninstalled WordPress sites (code only), so we'll remove this check.

…that file to be present when detecting WordPress installs.
@coveralls
Copy link

coveralls commented Dec 12, 2018

Pull Request Test Coverage Report for Build 25

  • 0 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 48.649%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Inspectors/WordPressInspector.php 0 4 0.0%
Totals Coverage Status
Change from base Build 24: 0.4%
Covered Lines: 54
Relevant Lines: 111

💛 - Coveralls

@greg-1-anderson greg-1-anderson merged commit 9581460 into master Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants