Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make map_signif_level more flexible #52

Merged
merged 6 commits into from Feb 20, 2019
Merged

make map_signif_level more flexible #52

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8c1e747
use .Machine$double.eps instead of hard-coded 2e-16
ilia-kats Feb 13, 2019
58b7e0b
map_signif_level can now take a user-supplied function to format the …
ilia-kats Feb 13, 2019
776bc8b
document new option for map_signif_level
ilia-kats Feb 13, 2019
602e509
don't draw legend key
ilia-kats Feb 15, 2019
9447d98
fix parentheses
ilia-kats Feb 18, 2019
47363ea
revert default p-value to just the number, add example of custom mapp…
ilia-kats Feb 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion R/significance_annotation.R
View file
Open in desktop
Expand Up @@ -215,7 +215,7 @@ GeomSignif <- ggplot2::ggproto("GeomSignif", ggplot2::Geom,
required_aes = c("x", "xend", "y", "yend", "annotation"),
default_aes = ggplot2::aes(shape = 19, colour = "black", textsize = 3.88, angle = 0, hjust = 0.5,
vjust = 0, alpha = NA, family = "", fontface = 1, lineheight = 1.2, linetype=1, size=0.5),
draw_key = ggplot2::draw_key_point,
draw_key = function(...){grid::nullGrob()},
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this change do?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

completely prevents drawing of a legend key for the ggsignif layer. In my case, I was trying to use ggsignif with geom_sina from ggforce and kept getting weird errors until I made this change.


draw_group = function(data, panel_params, coord) {
coords <- coord$transform(data, panel_params)
Expand Down