Skip to content
This repository has been archived by the owner on Mar 6, 2020. It is now read-only.

Add CXXFiles to TestPackage #716

Merged
merged 2 commits into from
May 10, 2017
Merged

Conversation

lukejohnston
Copy link
Contributor

With a project layout like this:

.
└── src
    └── proj
        ├── a
        │   ├── a.cpp
        │   ├── a.go
        │   └── a.h
        └── main.go

the test command will give a linker error when processing the a directory. This is because the .cpp files are not added to the test package. This change adds the .cpp files to the test package.

@davecheney
Copy link
Contributor

davecheney commented May 10, 2017 via email

@codecov-io
Copy link

codecov-io commented May 10, 2017

Codecov Report

Merging #716 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #716      +/-   ##
==========================================
+ Coverage   52.83%   52.85%   +0.01%     
==========================================
  Files          42       42              
  Lines        3155     3156       +1     
==========================================
+ Hits         1667     1668       +1     
  Misses       1344     1344              
  Partials      144      144
Impacted Files Coverage Δ
test/test.go 72.48% <100%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ab23c1...ec09189. Read the comment docs.

@lukejohnston
Copy link
Contributor Author

Sure, done. Thanks for the quick reply.

@davecheney
Copy link
Contributor

LGTM. Thanks.

@davecheney davecheney merged commit 5d12bf5 into constabulary:master May 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants