Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2D Probabilistic UNet Training Setup #123

Merged
merged 7 commits into from
Apr 29, 2023

Conversation

anwai98
Copy link
Contributor

@anwai98 anwai98 commented Apr 27, 2023

  • PUNet Source Training Workflow

(TODO: evaluation script will follow)

Copy link
Owner

@constantinpape constantinpape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few minor comments; looks good overall.

torch_em/self_training/probabilistic_unet_trainer.py Outdated Show resolved Hide resolved
torch_em/self_training/probabilistic_unet_trainer.py Outdated Show resolved Hide resolved
torch_em/self_training/probabilistic_unet_trainer.py Outdated Show resolved Hide resolved
torch_em/self_training/probabilistic_unet_trainer.py Outdated Show resolved Hide resolved
@anwai98
Copy link
Contributor Author

anwai98 commented Apr 28, 2023

The PUNet Source workflow is completed now. Just updated the pipeline for source evaluations. Thanks!

Copy link
Owner

@constantinpape constantinpape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, otherwise this looks good.
I am looking into the test failure here now: #124

@@ -23,6 +23,7 @@
from torch_em.util import load_model

CELL_TYPES = ["A172", "BT474", "BV2", "Huh7", "MCF7", "SHSY5Y", "SkBr3", "SKOV3"]
DEVICE = torch.device("cuda" if torch.cuda.is_available() else "cpu")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a good idea to declare globally, and I also don't see that you use it anywhere.

@constantinpape constantinpape merged commit 1f8138a into constantinpape:main Apr 29, 2023
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants