Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to MoNuSeg #157

Merged
merged 9 commits into from
Oct 20, 2023
Merged

Updates to MoNuSeg #157

merged 9 commits into from
Oct 20, 2023

Conversation

anwai98
Copy link
Contributor

@anwai98 anwai98 commented Oct 18, 2023

  • Added processing for the monuseg inputs (including xml to numpy array conversion) (kept the expected directory formats consistent)
  • (WIP) Add the test split
  • (TODO) Check the organ splits from the challenge's metadata and make those splits (mentioned in TODOs)

Copy link
Owner

@constantinpape constantinpape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @anwai98 ,
not sure if this is ready to review yet, but I had a quick look. In addition to the comments in the code, I tried the download, but it fails with

Access denied with the following error:

        Cannot retrieve the public link of the file. You may need to change
        the permission to 'Anyone with the link', or have had many accesses. 

You may still be able to access the file from the browser:

         https://drive.google.com/uc?export=download&id=1ZgqFJomqQGNnsx7w7QBzQQMVA16lbVCA 

torch_em/data/datasets/monuseg.py Outdated Show resolved Hide resolved
torch_em/data/datasets/monuseg.py Outdated Show resolved Hide resolved
@anwai98
Copy link
Contributor Author

anwai98 commented Oct 18, 2023

Hi @anwai98 , not sure if this is ready to review yet, but I had a quick look. In addition to the comments in the code, I tried the download, but it fails with

Access denied with the following error:

        Cannot retrieve the public link of the file. You may need to change
        the permission to 'Anyone with the link', or have had many accesses. 

You may still be able to access the file from the browser:

         https://drive.google.com/uc?export=download&id=1ZgqFJomqQGNnsx7w7QBzQQMVA16lbVCA 

Hmm, pretty interesting. I just tried it again and the download works for me. Is it related to the gdown version?
It works with the following version for me:

gdown                     4.7.1              pyhd8ed1ab_0    conda-forge

@anwai98 anwai98 marked this pull request as draft October 19, 2023 15:07
@constantinpape constantinpape marked this pull request as ready for review October 19, 2023 15:23
Copy link
Owner

@constantinpape constantinpape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good in principle, but do you still want to implement the organ selection before we merge it?

@anwai98
Copy link
Contributor Author

anwai98 commented Oct 19, 2023

This looks good in principle, but do you still want to implement the organ selection before we merge it?

Yes, I wanted to complete the setup, hence took it back as a draft. Would take care of it and put it back to review later. Thanks.

@constantinpape constantinpape merged commit 4e5e755 into constantinpape:main Oct 20, 2023
0 of 2 checks passed
@anwai98 anwai98 deleted the aa-monuseg branch November 8, 2023 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants