Fix MAE Initialization #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torch_em/model/unetr.py
Outdated
|
|
||
| # let's remove the `head` from our current encoder (as the MAE pretrained don't expect it) | ||
| current_encoder_state = self.encoder.state_dict() | ||
| if "head.weight" and "head.bias" in current_encoder_state: |
There was a problem hiding this comment.
This only checks if "head.bias" in current_encoder_state. "head.weight" is evaluated as an independent expression and will always evaluate to True.
There was a problem hiding this comment.
Ah my bad. I just overlooked it. Thanks for pointing. It's fixed now!
|
Thanks for figuring it out! There's a minor issue in the code to fix. More general: it's a bit unfortunate that we hard-code the image size like this, but I think we can't do much about this for now; I will create a more long term issue on that later. |
constantinpape
approved these changes
Dec 10, 2023
constantinpape
merged commit 8b27b49
into
constantinpape:more-loss-updates
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.