Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ASEM dataset #226

Merged
merged 11 commits into from
Apr 12, 2024
Merged

Add ASEM dataset #226

merged 11 commits into from
Apr 12, 2024

Conversation

anwai98
Copy link
Contributor

@anwai98 anwai98 commented Mar 12, 2024

No description provided.

@anwai98 anwai98 marked this pull request as ready for review March 13, 2024 22:40
@anwai98
Copy link
Contributor Author

anwai98 commented Mar 14, 2024

@constantinpape Let me know if you spot something. I will check later today where are the tests failing and confirm about it here.

@constantinpape
Copy link
Owner

The tests are failing because of new bioimageio releases, and it should be enough to wait for everything to catch up.

But I don't want to merge this yet, as the downloads are still excessive and can be done much more efficiently with zarr. I can take care of that.

@anwai98
Copy link
Contributor Author

anwai98 commented Mar 15, 2024

The tests are failing because of new bioimageio releases, and it should be enough to wait for everything to catch up.

But I don't want to merge this yet, as the downloads are still excessive and can be done much more efficiently with zarr. I can take care of that.

Okay, then I continue my experiments on this dataset in this branch (with the current download setup).

@constantinpape
Copy link
Owner

I will go ahead and merge this now. There is still some possibilities to make downloading the data much more efficient, but let's leave this to follow up work. I will create an issue on that.

@constantinpape constantinpape merged commit 3a02a99 into constantinpape:main Apr 12, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants